On Fri, May 17, 2019 at 7:34 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Johannes Sixt <j6t@xxxxxxxx> writes: > > > I'd prefer to keep this list at the minimum necessary as long as it is > > hard-coded in C. > > Yeah, I know that feeling. > So do we reach a consensus? Should I merge the Octave rules into Matlab rules? Best regards, Boxuan > > I would take a different stance if this were some > > configuration file that we ship. > > Hmm, now you reminded me of my ancient wish. > > Perhaps it is not too bad to ship $(sharedir)/git-core/userdiff that > can be read using git_config_from_file() interface, using a very > narrow callback function that understands only diff.*.xfuncname and > diff.*.wordregex and discards everything else, without even > following the include/includeIf stuff? As long as that can be done > safely and without too much overhead, we could get rid of the > hardcoded patterns in userdiff.c::builtin_drivers[] and that would > be wonderful ;-) >
