On Fri, May 17, 2019 at 12:35 PM Jeff King <peff@xxxxxxxx> wrote: > As it turns out, index-pack does not handle these complicated cases at > all! In the final fix_unresolved_deltas(), we are only looking for thin > deltas, and anything that was not yet resolved is assumed to be a thin > object. In many of these cases we _could_ resolve them if we tried > harder. But that is good news for us because it means that these > expectations about delta relationships are already there, and the > pre-fetch done by your patch should always be 100% correct and > efficient. Is it worth keeping some of these notes in the "third pass" comment block in index-pack.c to help future readers? -- Duy
