Todd Zullinger wrote: > The JGIT prereq uses 'type jgit' to determine whether jgit is present. > While this should be sufficient, if the jgit found is broken we'll waste > time running tests which fail due to no fault of our own. > > Use 'jgit --version' instead, to catch some badly broken jgit > installations. > > Signed-off-by: Todd Zullinger <tmz@xxxxxxxxx> > --- > I ran into such a broken jgit on Fedora >= 30¹. This is clearly a > problem in the Fedora jgit package which will hopefully be resolved > soon. But it may be good to avoid wasting time debugging tests which > fail due to a broken tool outside of our control. > > ¹ https://bugzilla.redhat.com/1709624 Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> It would be nice to describe that bug in the commit message, to save readers some head scratching. Thanks, Jonathan
