On 5/9/2019 5:25 PM, Jeff King wrote: > This is a continuation of my efforts to get us compiling with > -Wunused-parameter. This round finishes most of the cleanups and fixes > I intend to do (though I have a handful of cleanup cases that I'm still > poking at to make sure they're not in fact bugs). After that, I have > some patches to annotate unused parameters we can't get rid of (e.g., > for cases where we're conforming to a callback interface), and then we > can finally flip the warning on for developer-mode. This series looks correct to me. I look forward to having the warning on in developer mode! Thanks, -Stolee
