Hi, On Thu, 12 Jul 2007, skimo@xxxxxxxx wrote: > diff --git a/git-compat-util.h b/git-compat-util.h > index 362e040..1a36f4c 100644 > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -325,12 +325,15 @@ static inline int has_extension(const char *filename, const char *ext) > extern unsigned char sane_ctype[256]; > #define GIT_SPACE 0x01 > #define GIT_DIGIT 0x02 > -#define GIT_ALPHA 0x04 > +#define GIT_HEXAL 0x04 > +#define GIT_OTHAL 0x08 > +#define GIT_ALPHA (GIT_HEXAL | GIT_OTHAL) I'd have left GIT_ALPHA, and added GIT_HEXDIGIT. > #define sane_istest(x,mask) ((sane_ctype[(unsigned char)(x)] & (mask)) != 0) > #define isspace(x) sane_istest(x,GIT_SPACE) > #define isdigit(x) sane_istest(x,GIT_DIGIT) > #define isalpha(x) sane_istest(x,GIT_ALPHA) > #define isalnum(x) sane_istest(x,GIT_ALPHA | GIT_DIGIT) > +#define ishex(x) sane_istest(x,GIT_HEXAL | GIT_DIGIT) I know, I originally proposed this. In the mean time, however, I found that this gem should be even better (in terms of diff size): #define ishex(x) (hexval(x) >= 0) Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
