On Thu, May 09, 2019 at 04:06:22PM +0200, Johannes Schindelin wrote: > > I don't this this has anything to do with gcc. The point is that we > > already have this line: > > > > write_or_die(fd, buf, BLOCKSIZE); > > > > which does not cast and nobody has complained, > > I mistook this part of your reply in > https://public-inbox.org/git/20190413013451.GB2040@xxxxxxxxxxxxxxxxxxxxx/ > as precisely such a complaint: > > BLOCKSIZE is a constant. Should we be defining it with a "U" in > the first place? Ah, sorry to introduce confusion. I mostly meant "if we need to cast, why not just define as unsigned in the first place?". But I think René was pointing out that we do not even need to cast, and I am fine with that approach. I do dream of a world where we do not have a bunch of implicit conversions (both signedness but also truncation) in our code base, and can compile cleanly with -Wconversion We know that this case is perfectly fine, but I am sure there are many that are not. However, I'm not sure if we'll ever get there, and in the meantime I don't think it's worth worrying too much about individual cases like this. -Peff
