> So we're going to stop setting OMIT_STATUS ever, which makes sense. > > It took me a minute to figure out here that the behavior for VERBOSE is > not changed, because we _overwrite_ flags, rather than just setting a > single bit. But that's definitely the right thing to do when there's a > format (both before and after your patch). > > So this looks good to me. I think we should probably cover it with a > test in t7004. Yes, that's something that surprised me originally, as these changes don't make the test suite break in any way... I'll add a patch to the series with a test for this. Thanks for the review! -Santiago.
Attachment:
signature.asc
Description: PGP signature
