Matthew DeVore wrote: > On 2019/05/06, at 12:46, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: >> Ah, interesting. When this was discussed before, the proposal has been >> that the client can say "have" anyway. They don't have the commit and >> all referenced objects, but they have the commit and a *promise* that >> they can obtain all referenced objects, which is almost as good. >> That's what "git fetch" currently implements. > > Doesn’t that mean the “have” may indicate that the client has the > entire repository already, even though it’s only a partial clone? If > so, then the client intends to ask for some tree plus trees and > blobs 2-3 levels down deeper, how would the server distinguish > between those objects the client *really* has and those that were > just promised to them? Because the whole purpose of this > hypothetical request is to get a bunch of promises fulfilled of > which 0-99% are fulfilled already. For blobs, the answer is simple: the server returns any object explicitly named in a "want", even if the client already should have it. For trees, the current behavior is the same: if you declare that you "have" everything, then if you "want" a tree with filter tree:2, you only get that tree. So here there's already room for improvement. [...] > Maybe something like this (conceptually based on original proposal) ? > > 1. Client sends request for an object or objects with an extra flag > which means “I can’t really tell you what I already have since it’s > a chaotic subset of the object database of the repo” > > 2. Server responds back with set of objects, represented by deltas > if that is how the server has them on disk, along with a list of > object-IDs needed in order to resolve the content of all the > objects. These object-IDs can go several layers of deltas back, and > they go back as far as it takes to get to an object stored in its > entirety by the server. > > 3. Client responds back with another request (this time the extra > flag sent from step 1 is not necessary) which has “want”s for every > object the server named which the client already has. > > Very hand-wavey, but I think you see my idea. The only downside I see is that the list of objects may itself be large, and the server has to check reachability for each one. But maybe that's fine. Perhaps after that initial response, instead of sending the list of individual objects the client wants, it could send a list of relevant objects it has (combined with the original set of "want"s). That could be a smaller request and it means less work for the server to check each "want" for reachability. What do you think? [...] > That's a very good point. The data the first request gives us is > basically the tree objects minus file names and modes. So I think a > better feature to implement would be combining of multiple filters. > That way, the client can combine "tree:<some small number>" and > "blob:none" and basically get an "enumeration" of available objects. This might be simpler. Combining filters would be useful for other uses, too. Thanks, Jonathan
