Re: [PATCH 3/6] config.c: add repo_config_set_worktree_gently()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 30, 2019 at 11:40 PM Derrick Stolee <stolee@xxxxxxxxx> wrote:
>
> On 12/27/2018 10:56 AM, Nguyễn Thái Ngọc Duy wrote:
> > diff --git a/config.h b/config.h
> > index ee5d3fa7b4..62204dc252 100644
> > --- a/config.h
> > +++ b/config.h
> > @@ -103,6 +103,9 @@ extern int git_config_color(char *, const char *, const char *);
> >  extern int git_config_set_in_file_gently(const char *, const char *, const char *);
> >  extern void git_config_set_in_file(const char *, const char *, const char *);
> >  extern int git_config_set_gently(const char *, const char *);
> > +extern int repo_config_set_gently(struct repository *, const char *, const char *);
> > +extern void repo_config_set(struct repository *, const char *, const char *);
> > +extern int repo_config_set_worktree_gently(struct repository *, const char *, const char *);
> >  extern void git_config_set(const char *, const char *);
> >  extern int git_config_parse_key(const char *, char **, int *);
> >  extern int git_config_key_is_valid(const char *key);
>
> I know this is an old thread, but the patch is still in 'pu'. These methods
> do not appear to have any callers. Perhaps this patch should be dropped
> until there is a reason to include it?

That series was broken down to test the water before the whole
sumodule support on multiple worktree series enters. But since this
series is not going anyway, don't worry I don't think it will ever
enter 'master'.

> Thanks,
> -Stolee



-- 
Duy




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux