Hi Eric, On Mon, 29 Apr 2019, Eric Sunshine wrote: > On Mon, Apr 29, 2019 at 6:04 PM Thomas Braun via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: > > Since commit 0c499ea60f (send-pack: demultiplex a sideband stream with > > status data, 2010-02-05) the built-in send-pack uses the side-band-64k > > capability if advertised by the server. > > > > Unfortunately this breaks pushing over the dump git protocol if used > > s/dump/dumb/ Of course! > > over a network connection when using MinGW (but *not* when using > > mingw-w64). > > [...] > > The new config option "sendpack.sideband" allows to override the > > side-band-64k capability of the server, and thus makes the dump git > > protocol work. > > [...] > > Signed-off-by: Thomas Braun <thomas.braun@xxxxxxxxxxxxxxx> > > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > --- > > diff --git a/Documentation/config/sendpack.txt b/Documentation/config/sendpack.txt > > @@ -0,0 +1,5 @@ > > +sendpack.sideband:: > > + Allows to disable the side-band-64k capability for send-pack even > > + when it is advertised by the server. Makes it possible to work > > + around a limitation in the git for windows implementation together > > + with the dump git protocol. Defaults to true. > > s/dump/dumb/ > > For someone who hasn't read the commit message of this patch, "work > around a limitation in ... git for windows" doesn't mean much. Perhaps > this documentation could explain in more precise terms under what > circumstances this option should be used? You're right, this is confusing, especially since Git for Windows 2.x does not have that bug. I simply dropped that sentence. Thanks! Dscho
