On Sun, Apr 28, 2019 at 10:19:41PM -0700, nbelakovski@xxxxxxxxx wrote: > From: Nickolai Belakovski <nbelakovski@xxxxxxxxx> > > Added test_i18ncmp per instructions from Szeder > > Is there some other part of the infrastructure that's testing for this? Because it did not fail in any of my Travis CI builds. > > Travis CI results: https://travis-ci.org/nbelakovski/git/builds/525801210 Testing with GETTEXT_POISON was broken since 6cdccfce (i18n: make GETTEXT_POISON a runtime option, 2018-11-08), and didn't catch any of these issues. See: https://public-inbox.org/git/xmqqlg0bvppc.fsf_-_@xxxxxxxxxxxxxxxxxxxxxxxxx/T/#u The fix f88b9cb603 (gettext tests: export the restored GIT_TEST_GETTEXT_POISON, 2019-04-15) was merged to master just last week.