"Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> > > The write_commit_graph() and write_commit_graph_reachable() methods > currently take two boolean parameters: 'append' and 'report_progress'. > We will soon expand the possible options to send to these methods, so > instead of complicating the parameter list, first simplify it. > > Collapse these parameters into a 'flags' parameter, and adjust the > callers to provide flags as necessary. Nice. It would make more sense for a collection of independent bits to be in an unsigned, not signed integer variable, though. Unless you assign some special meaning to the top-most bit, that is.
