Jeff King <peff@xxxxxxxx> writes: >> This is obviously inherited from the original, but do we get scolded >> by some versions of bash for this line, without quoting the source path >> of the redirection, i.e. >> >> ... --stdin <"$PACK" > > In general, yes, but I think we are OK in this instance because we > generated $PACK ourselves in the setup step, and we know that it is just > a relative .git/objects/pack/xyz.pack with no spaces. I know we are OK, but the issue with some versions of bash AFAIU is that bash is not OK regardless of the contents of $variable that is not quoted and used as the target or the source of a redirection, issuing an unnecessary warning.