On 4/21/19 8:35 PM, Duy Nguyen wrote: > On Sun, Apr 21, 2019 at 6:40 PM Andrew Janke <floss@xxxxxxxxxxx> wrote: >> >> Hi, Git folks, >> >> This is a follow-up to https://marc.info/?l=git&m=154757938429747&w=2. > > This says the problem with "en" detection has been fixed. Would > upgrading gettext fix it? > > You would need to upgrade something (git or gettext) and if it's > already fixed in gettext I don't see why we need a workaround in git. >From reading the bug report, that does sound like it would fix it. But from what I can see, that fix hasn't made it out into a released version of gettext yet. I haven't downloaded the development gettext to confirm the fix. Looking at the gettext ftp site at https://ftp.gnu.org/pub/gnu/gettext/, it looks like gettext does not make frequent releases, and the last release was two and a half years ago. Who knows when the next release will be. And then it'll take longer to trickle down into Linux distributions and such. >From your release history at https://github.com/git/git/releases, it seems like Git is a lot more active in making releases than gettext. So including this fix in Git would get it into the hands of affected users sooner. And it seems like a pretty low-risk change to me. Then once the new gettext release is out, their fix is confirmed, and it makes it out into common distros, the workaround could be removed from Git. Cheers, Andrew
