On 4/13/19 11:54 PM, Junio C Hamano wrote:
Two thoughts.
- Unless the 'old heuristic' is still available as an option after
this step, a series that first begins with the 'old heuristic'
and then later replaces it with the 'new heuristic' feels
somewhat wasteful of reviewer resources, as the 'old heuristic'
does not contribute an iota to the end result.
It is OK while the series is still in RFC/WIP stage, though. But
because I got an impression that this is close to completion, so...
Can do. I wasn't sure yet where things were going, but in the final
version, I can yank out the old heuristic from the patch set.
Though the old heuristic is pretty basic - really just a couple lines -
and it may help to see it before looking at a more complicated version.
Especially since it helps break the commit up into "infrastructure to
ignore commits" and "brains to find the right commit to blame" while
still being functional between the commits.
Thanks,
Barret
