Hi Eric, On Tue, Apr 09, 2019 at 04:02:23AM -0400, Eric Sunshine wrote: > On Tue, Apr 9, 2019 at 1:09 AM Taylor Blau <me@xxxxxxxxxxxx> wrote: > > On Mon, Apr 08, 2019 at 11:28:19PM -0400, Eric Sunshine wrote: > > > I suspect that Junio's "Looks good" was referring to the 'sed expression. > > > > I think that you are right -- and I'll happily _not_ introduce more Git > > on the left-hand-side of a pipe instances. > > > > I noticed a few more instances in t6102 [...] > > Indeed, SZEDER mentioned those in [1]: Aha, thanks -- I'm not sure how I missed that in [1]. Credit is given where it is due :-). > Don't run git commands upstream of a pipe, because the pipe > hides their exit code. This applies to several other tests > below as well. > > [1]: http://public-inbox.org/git/20190405105033.GT32732@xxxxxxxxxx/ > > > I wrote the following patch, which I've folded into my local copy (and > > will send with v2): > > > > > With all the recent work of moving away from having Git upstream of a > > > pipe, let's not intentionally introduce a new instance. I wrote the > > > example 'sed' expression that way merely to mirror how the original > > > 'perl' version was written to make it easier to see the equivalence > > > (not because it was intended as an endorsement of having Git upstream > > > of a pipe). > > > > I see, and thank you for the clarification. Let me know if you like the > > patch above. > > Looks fine. Thanks. Great -- I appreciate your review. I'll send v2 shortly with these changes in it. Thanks, Taylor
