Am 09.04.2019 um 07:53 schrieb Torsten Bögershausen: >> Regression was introduced in commit >> 25d90d1cb72ce51407324259516843406142fe89. > > Was it ? > 25d90d1cb merged this commit: > 1cadad6f6 (junio/tb/use-common-win32-pathfuncs-on-cygwin) Yes, I copied the revision of the merge commit. > And, if I read that correctly, 1cadad6f6 does not change anything for MSVC. > And the problem with the missing/wrong path resolution was there before > 1cadad6f6 and after 1cadad6f6. That's not correct, it was correct before: 1cadad6f6 removes mingw_offset_1st_component from mingw.c which is included by msvc.c. Then the in git-compat.h the new file "compat/win32/path-utils.h" is only included for __CYGWIN__ and __MINGW32__, here _MSC_VER is missing -> that's the regression. > In config.mak.uname we need to add a line > compat/win32/path-utils.o > for the Windows build. > In the git-for windows codebase I see > COMPAT_OBJS +=compat/win32/path-utils I don't use config.mak.uname and never did, so I can't tell you about that. -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server
