On Mon, Apr 8, 2019 at 9:59 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Christian Couder <christian.couder@xxxxxxxxx> writes: > > > I will at least add something telling that in most cases > > "repository_format_partial_clone" and fetch_objects() shouldn't be > > used directly anymore. > > Yes, that would be necessary not in the log, but in-code comments > next to now "by-exception-only" API functions and variables. Ok, I will add in-code comments then, or ... > >> Likewise between fetch_objects() and promisor_remote_get_direct(). > >> Shouldn't the underlying fetch_objects be hidden from general > >> callers? > > > > I will see if I can do that, though it has to be used in promisor-remote.c. > > Does fetch-objects.[ch] even need to exist after multi-promisor > world as an external interface? > > Wouldn't it become an implementation detail of promisor-remote.[ch] > API? ... yeah, I will try this.
