Re: [PATCH] fixup! diff: batch fetching of missing blobs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] fixup! diff: batch fetching of missing blobs
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Mon, 08 Apr 2019 12:46:22 +0900
Cc: Jonathan Tan <jonathantanmy@xxxxxxxxxx>, Git Mailing List <git@xxxxxxxxxxxxxxx>
In-reply-to: <CACsJy8AjyY1Azbf4VfnJMA3O8NNBV1P16dZRrHOUJdsYQHUu4g@mail.gmail.com> (Duy Nguyen's message of "Sat, 6 Apr 2019 11:17:46 +0700")
References: <CACsJy8CgXLZxqab4vcP1jh3OMCGh1i=easb5BpCs1J8Uf_jsxw@mail.gmail.com> <20190405170934.20441-1-jonathantanmy@google.com> <CACsJy8AjyY1Azbf4VfnJMA3O8NNBV1P16dZRrHOUJdsYQHUu4g@mail.gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Duy Nguyen <pclouds@xxxxxxxxx> writes:

>> -static void add_if_missing(struct oid_array *to_fetch,
>> +static void add_if_missing(struct oid_array *to_fetch, struct repository *r,
>
> One last nit. "struct repository *r" is often the first argument. See

Yes, and that's easy enough to tweak locally ;-)

Thanks.

References:
- Re: [PATCH v2 2/2] diff: batch fetching of missing blobs
  - From: Duy Nguyen
- [PATCH] fixup! diff: batch fetching of missing blobs
  - From: Jonathan Tan
- Re: [PATCH] fixup! diff: batch fetching of missing blobs
  - From: Duy Nguyen

Prev by Date: Re: [GSoC][RFC] Proposal: Make pack access code thread-safe
Next by Date: Re: [PATCH] fixup! diff: batch fetching of missing blobs
Previous by thread: Re: [PATCH] fixup! diff: batch fetching of missing blobs
Next by thread: Re: [PATCH] fixup! diff: batch fetching of missing blobs
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux