On Sat, Apr 6, 2019 at 7:14 PM Kapil Jain <jkapil.cs@xxxxxxxxx> wrote: > > In some cases, it will be simple. For example, if you have a look at > > repo_read_index(), it already knows what repo it handles, so you can > > just extend read_index_from() to take 'struct repository *' and pass > > 'repo' to it. > > > > Be careful though, repository and istate does not have one-to-one > > relationship (I'll leave it to you to find out why). So you cannot > > replace > > should i run all the tests after making the changes, or are there some > specific ones. 'make test' (with -j<something> to speed up) should always be done for any kind of changes. But I'm pretty sure you'll hit plenty compiler errors that will make you pause and think. -- Duy
