Jeff King <peff@xxxxxxxx> writes: > This patch series started with patch 12: I just wanted to drop the > unused "force" parameter from update_info_refs(). > > But that made me look at its sibling update_info_packs(), and whether it > ... > And here we are. I present them here in reverse rabbit-hole order (which > is also roughly important fixes first, and minor cleanups last). The > individual chunks are mostly independent, but the server-info cleanups > rely on the shared pack_basename() helper added as part of the midx fix. A kind of cover letter to make readers chuckle. Well written. And of course, thanks. It's a delight to read a nicely constructed series like this one. > > [01/12]: t5319: fix bogus cat-file argument > [02/12]: t5319: drop useless --buffer from cat-file > [03/12]: packfile: factor out .pack to .idx name conversion > [04/12]: packfile: check midx coverage with .idx rather than .pack > [05/12]: http: simplify parsing of remote objects/info/packs > [06/12]: server-info: fix blind pointer arithmetic > [07/12]: server-info: simplify cleanup in parse_pack_def() > [08/12]: server-info: use strbuf to read old info/packs file > [09/12]: server-info: drop nr_alloc struct member > [10/12]: packfile.h: drop extern from function declarations > [11/12]: server-info: drop objdirlen pointer arithmetic > [12/12]: update_info_refs(): drop unused force parameter > > http.c | 35 ++++++--------- > packfile.c | 31 ++++++++++--- > packfile.h | 86 ++++++++++++++++++++----------------- > server-info.c | 57 +++++++++++------------- > t/t5319-multi-pack-index.sh | 29 ++++++++++--- > 5 files changed, 132 insertions(+), 106 deletions(-) > > -Peff
