Earlier in the mailing list, Robert Dailey reported confusion over some nested tags. [1] Peff noted that he hasn't seen a tag-to-a-tag in the wild so in most cases, it'd probably be a mistake on the part of a user. He also suggested we error out on a nested tag unless "--allow-nested-tag" is provided. [2] This patchset implements those suggestions. Changes since v1: * Squashed patches into two patches, one to clean up tag.c, one to do the rest * s/recursive/nested/g (so the new option is --allow-nested-tag) * Add more details to --allow-nested-tag documentation [1]: https://public-inbox.org/git/CAHd499BM91tf7f8=phR4Az8vMsHAHUGYsSb1x9as=WukUVZHJw@xxxxxxxxxxxxxx/ [2]: https://public-inbox.org/git/20190325144930.GA19929@xxxxxxxxxxxxxxxxxxxxx/ Denton Liu (2): tag: fix formatting tag: prevent nested tags Documentation/config/advice.txt | 2 ++ Documentation/git-tag.txt | 16 +++++++++++++++- advice.c | 2 ++ advice.h | 1 + builtin/tag.c | 30 ++++++++++++++++++++++++++---- t/annotate-tests.sh | 2 +- t/t0410-partial-clone.sh | 2 +- t/t4205-log-pretty-formats.sh | 2 +- t/t5305-include-tag.sh | 2 +- t/t5500-fetch-pack.sh | 2 +- t/t6302-for-each-ref-filter.sh | 4 ++-- t/t7004-tag.sh | 12 ++++++++++-- t/t9350-fast-export.sh | 4 ++-- 13 files changed, 65 insertions(+), 16 deletions(-) -- 2.21.0.741.g2c528c8f87
