Hi Ævar, On Wed, 27 Mar 2019, Johannes Schindelin wrote: > On Tue, 26 Mar 2019, Ævar Arnfjörð Bjarmason wrote: > > > On Mon, Mar 25 2019, Johannes Schindelin via GitGitGadget wrote: > > > > > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > > > > Since 7ded055401 (build: do not install git-remote-testgit, 2013-06-07), > > > we do not install it. Therefore it makes no sense to document it, > > > either. > > > > > > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > --- > > > Documentation/git-remote-testgit.txt | 30 ---------------------------- > > > Documentation/gitremote-helpers.txt | 2 -- > > > 2 files changed, 32 deletions(-) > > > delete mode 100644 Documentation/git-remote-testgit.txt > > > > > > diff --git a/Documentation/git-remote-testgit.txt b/Documentation/git-remote-testgit.txt > > > deleted file mode 100644 > > > index b45bfebba5..0000000000 > > > --- a/Documentation/git-remote-testgit.txt > > > +++ /dev/null > > > @@ -1,30 +0,0 @@ > > > -git-remote-testgit(1) > > > -===================== > > > - > > > -NAME > > > ----- > > > -git-remote-testgit - Example remote-helper > > > - > > > - > > > -SYNOPSIS > > > --------- > > > -[verse] > > > -git clone testgit::<source-repo> [<destination>] > > > - > > > -DESCRIPTION > > > ------------ > > > - > > > -This command is a simple remote-helper, that is used both as a > > > -testcase for the remote-helper functionality, and as an example to > > > -show remote-helper authors one possible implementation. > > > - > > > -The best way to learn more is to read the comments and source code in > > > -'git-remote-testgit'. > > > - > > > -SEE ALSO > > > --------- > > > -linkgit:gitremote-helpers[7] > > > - > > > -GIT > > > ---- > > > -Part of the linkgit:git[1] suite > > > diff --git a/Documentation/gitremote-helpers.txt b/Documentation/gitremote-helpers.txt > > > index 34a3e60d08..2fc4007525 100644 > > > --- a/Documentation/gitremote-helpers.txt > > > +++ b/Documentation/gitremote-helpers.txt > > > @@ -513,8 +513,6 @@ linkgit:git-remote-ext[1] > > > > > > linkgit:git-remote-fd[1] > > > > > > -linkgit:git-remote-testgit[1] > > > - > > > linkgit:git-fast-import[1] > > > > I wonder if it should be moved into e.g. t/helper or somesuch at this > > point... > > Sure. > > One thing to keep in mind is that we cannot change the actual name of the > executable, as it needs to have the format `git-remote-*`, and cannot > require a first argument `testgit`, to be able to perform its purpose. > > We do have a precedent for that kind of scenario: `test-fake-ssh`. It is > also not folded into `test-tool`, and it is copied while changing the name > to `ssh`, as required to fulfill its mission. > > I am not totally enthusiastic about this because this is what prevents > Git's test suite from running in a RAM disk on Windows, IIRC: I have not > been able to convince my RAM disk provider to allow executables stored on > it to be executed. Oh you know what? `git-remote-testgit` is a *shell script*. So that one was easy... Now, the question is really, should I just add this patch *here*, or to the non-Windows-related docs fixes I have lined up? Decisions, decisions. Ciao, Dscho
