[Cc: git@xxxxxxxxxxxxxxx]
Miklos Vajna wrote:
> + ((defined $filter and $filter == "nomerges") ? ("--no-merges") : ()),
Shouldn't it be '$filter eq "nomerges"' instead?
Besides, I'd rather have generalized way to provide additional options
to git commands, like '--no-merges' for RSS and Atom feeds, log, shortlog
and history views, '-C' for commitdiff view, '--remove-empty' for history
view for a file, perhaps even '-c' or '--cc' for commitdiff for merges
instead of abusing 'hp' argument for that.
But that doesn't mean that this patch should be not applied... it doesn't
mean it should be applied neither ;-)
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
