Hi Johannes, On Wed, Mar 13, 2019 at 04:56:53AM -0700, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > On Windows, for example, executables (must) have the extension `.exe`. > Our `check-docs` target was not prepared for that. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 537493822b..df56bf0cd1 100644 > --- a/Makefile > +++ b/Makefile > @@ -3074,7 +3074,7 @@ ALL_COMMANDS += git-gui git-citool > .PHONY: check-docs > check-docs:: > $(MAKE) -C Documentation lint-docs > - @(for v in $(ALL_COMMANDS); \ > + @(for v in $(patsubst %$X,%,$(ALL_COMMANDS)); \ > do \ > case "$$v" in \ > git-merge-octopus | git-merge-ours | git-merge-recursive | \ > @@ -3103,7 +3103,7 @@ check-docs:: > -e 's/\.txt//'; \ > ) | while read how cmd; \ > do \ > - case " $(ALL_COMMANDS) " in \ > + case " $(patsubst %$X,%,$(ALL_COMMANDS)) " in \ I'm a little late to reading this thread, but I was curious why there are now two spaces around the patsubst as opposed to the one around ALL_COMMANDS? > *" $$cmd "*) ;; \ > *) echo "removed but $$how: $$cmd" ;; \ > esac; \ > -- > gitgitgadget Thanks, Taylor
