Hi Hannes, On Sat, 16 Mar 2019, Johannes Sixt wrote: > Am 16.03.19 um 10:49 schrieb Johannes Schindelin via GitGitGadget: > > diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh > > index 3e0a61db23..918bc323ab 100755 > > --- a/t/t7519-status-fsmonitor.sh > > +++ b/t/t7519-status-fsmonitor.sh > > @@ -346,4 +346,14 @@ test_expect_success UNTRACKED_CACHE 'ignore .git changes when invalidating UNTR' > > test_cmp before after > > ' > > > > +test_expect_failure 'discard_index() also discards fsmonitor info' ' > > + test_when_finished \ > > + "git config core.monitor .git/hooks/fsmonitor-test" && > > Did you mean > "git config core.fsmonitor ... > ? D'oh, yes. > > + test_config core.fsmonitor "$TEST_DIRECTORY/t7519/fsmonitor-all" && > > And then, does this not unset core.fsmonitor after the test anyway? It will unset it, as you point out, not *re-set* it to the value it had before. But I guess that's par for the course. I am just worried about side effects in our test suite. I run into those all the time, it is not even funny: when a prereq is not met, or when you just want to `--run=<this-one>`, you can't, because it is almost as if more than half of our test cases depend on the output of *some* previous test case. But you're right, I should not worry so much. After all, I am adding a test case to the *end* of the test script. Will send out a fixed version soon. Thanks, Dscho > > > + test_might_fail git update-index --refresh && > > + test-tool read-cache --print-and-refresh=tracked 2 >actual && > > + printf "tracked is%s up to date\n" "" " not" >expect && > > + test_cmp expect actual > > +' > > + > > test_done > > -- Hannes >
