Jeff King <peff@xxxxxxxx> writes: > Here's another round of -Wunused-parameter cleanups. Previous rounds > were at [1] and [2]. As before, these are mostly just removals, so it's > easy to see there's no behavior change (there are a couple of cleanups > that ride along, though, so watch for those). > > There are two minor conflicts when merging with pu: > > - jt/fetch-cdn-offload tweaked the "pack_lockfile" parameter to > fetch_pack(). A few other parameters are dropped in this series. > The textual resolution is pretty straightforward. > > - ps/stash-in-c (et al) added a new call to report_path_error() in > builtin/stash.c, which here loses its redundant "prefix" parameter. > There's no textual conflict, but the new call needs to drop its > final NULL parameter in order to compile. > > [1] https://public-inbox.org/git/20190214054736.GA20091@xxxxxxxxxxxxxxxxxxxxx/ > [2] https://public-inbox.org/git/20190124131104.GA24017@xxxxxxxxxxxxxxxxxxxxx/ > > The patches are: > > [01/13]: revision: drop some unused "revs" parameters > [02/13]: log: drop unused rev_info from early output > [03/13]: log: drop unused "len" from show_tagger() > [04/13]: update-index: drop unused prefix_length parameter from do_reupdate() > [05/13]: test-date: drop unused "now" parameter from parse_dates() > [06/13]: unpack-trees: drop name_entry from traverse_by_cache_tree() > [07/13]: unpack-trees: drop unused error_type parameters > [08/13]: report_path_error(): drop unused prefix parameter > [09/13]: fetch_pack(): drop unused parameters > [10/13]: parse-options: drop unused ctx parameter from show_gitcomp() > [11/13]: pretty: drop unused "type" parameter in needs_rfc2047_encoding() > [12/13]: pretty: drop unused strbuf from parse_padding_placeholder() > [13/13]: parse_opt_ref_sorting: always use with NONEG flag Nicely written. Thanks. > builtin/branch.c | 3 +-- > builtin/checkout.c | 2 +- > builtin/commit.c | 6 +++--- > builtin/fetch-pack.c | 2 +- > builtin/for-each-ref.c | 3 +-- > builtin/log.c | 18 +++++++++--------- > builtin/ls-files.c | 2 +- > builtin/ls-remote.c | 3 +-- > builtin/submodule--helper.c | 2 +- > builtin/tag.c | 3 +-- > builtin/update-index.c | 5 ++--- > dir.c | 3 +-- > dir.h | 2 +- > fetch-pack.c | 3 +-- > fetch-pack.h | 3 +-- > parse-options.c | 5 ++--- > pretty.c | 12 +++++------- > ref-filter.c | 9 +++++++-- > ref-filter.h | 5 +++++ > revision.c | 12 ++++++------ > t/helper/test-date.c | 4 ++-- > transport.c | 10 ++++------ > unpack-trees.c | 9 +++------ > 23 files changed, 60 insertions(+), 66 deletions(-) > > -Peff
