On Thu, Mar 14, 2019 at 01:34:32PM +0100, Ævar Arnfjörð Bjarmason wrote: > Addresse Peff's comments to v1. For a couple of patches I've faked up > his SOB where I copy/pasted a comment or code from a v1 comment > verbatim. Will see if he acks that. Yep, for the record, those are fine (actually, I guess one of them got axed in v3). > The main change is a better commit message in the last patch (now > 7/7), and 2x new "reflog" patches to make it early exit in addition to > "gc" when there's nothing to do. > > There was the "why do it at all in gc" feedback on 6/7 in v1. I've > adjusted the commit message there to justify it, but we'll see what > Peff things about it this time around... Even after reading your v3 reasoning, I still think it would probably be OK for git-reflog to treat the "never" case as a noop. But frankly it's not worth even spending any more brain cycles on. I can't imagine why somebody would bother to run "reflog expire" without any expiration, outside of git-gc. The improved commit messages all made sense to me (including the NULL oid bits in the final one), with the exception of one nit I pointed out in one of the v3 messages. -Peff
