Re: [WIP PATCH/RFC] Use a higher range-diff --creation-factor for format-patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:

> So, I'm fairly negative on this change. However, that doesn't mean I
> would oppose tweaking the value shared between the two programs (and
> also the default used by GitGitGadget, if it specifies it manually),
> though I defer to Dscho in that regard.

I do not think of a good reason why the command should behave
differently only when run from inside format-patch, and if we were
changing anything, perhaps raising it a bit for all may make sense.
I have yet to see range-diff getting confused and matching wrong
patches but often seee it being too conservative to match two
iterations of the same patch after a moderate amount of update.

I find myself passing "--creation-factor 99" or some absurdly
looking value when accepting a rerolled series.  The most recent was
the updated 'clean-up merge message with scissors' from Denton
[*1*].


[Footnote]

*1* <6716d28a5187c44c1d90f5ce840c44441f62352c.1552275703.git.liu.denton@xxxxxxxxx>
and <08426189b5a29b376581eb0172e52222ab22387a.1552817044.git.liu.denton@xxxxxxxxx>
do not line up without a high creation factor.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux