On Fri, Mar 15, 2019 at 02:25:45PM +0100, SZEDER Gábor wrote: > > Our reader implementation will ignore one of the bitmap files, but it's > > likely non-deterministic which one we will use. We'd prefer the one with > > the more recent timestamp (just because of the way the packed_git list > > is sorted), but in most test runs they'd have identical timestamps. > > > > So this was probably actually testing something useful about 50% of the > > time, and other half just testing that we could read our own bitmaps > > (which is covered elsewhere). > > At least it was testing the right thing up until 87a6bb701a > (t5310-pack-bitmaps: make JGit tests work with GIT_TEST_SPLIT_INDEX, > 2018-05-10) came along. Heh, indeed. I didn't even dig into the history, and just assumed I had botched it in 2013. :) -Peff
