> It fixes not just this issue, but now the whole test suite passes with > GIT_TEST_FSMONITOR, i.e. this test that's been failing for ~2 years also > works now: > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpubli > c- > inbox.org%2Fgit%2F87k1vwn9qe.fsf%40evledraar.gmail.com%2F&data= > 02%7C01%7CBen.Peart%40microsoft.com%7C758f6272cb9741291c0208d6a8 > d650b4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6368820357 > 67290383&sdata=H4J7xguBJVxanMfn4y0I0HsXBNYcrMS9IrwHn3aWwO > U%3D&reserved=0 > > >> In the meantime I did a build with "next" (so stash-in-C) using the > >> standard test mode and these: > >> > >> (cd t && GIT_TEST_GETTEXT_POISON=true /usr/bin/prove > $BKNG_GIT_HARNESS_OPTIONS t[0-9]*.sh) > >> (cd t && GIT_TEST_FSMONITOR=$PWD/t7519/fsmonitor-all > GIT_SKIP_TESTS="t3404.8 t3420.36" /usr/bin/prove > $BKNG_GIT_HARNESS_OPTIONS t[0-9]*.sh) > >> (cd t && GIT_TEST_SPLIT_INDEX=true /usr/bin/prove > $BKNG_GIT_HARNESS_OPTIONS t[0-9]*.sh) > >> (cd t && GIT_TEST_FULL_IN_PACK_ARRAY=true GIT_TEST_OE_SIZE=10 > /usr/bin/prove $BKNG_GIT_HARNESS_OPTIONS t[0-9]*.sh) > >> (cd t && GIT_TEST_COMMIT_GRAPH=true /usr/bin/prove > $BKNG_GIT_HARNESS_OPTIONS t[0-9]*.sh) > >> (cd t && GIT_TEST_MULTI_PACK_INDEX=true /usr/bin/prove > $BKNG_GIT_HARNESS_OPTIONS t[0-9]*.sh) > >> (cd t && GIT_TEST_STASH_USE_BUILTIN=false /usr/bin/prove > $BKNG_GIT_HARNESS_OPTIONS t[0-9]*.sh) > >> (cd t && GIT_TEST_CHECK_COLLISIONS=false /usr/bin/prove > >> $BKNG_GIT_HARNESS_OPTIONS t[0-9]*.sh) > >> > >> Only this specific test failed. > > > > Well, good! > > > > Thank you for getting the ball rolling! Awesome find and fix. Thanks for chasing this down and CC'ing me so I am aware. > > Dscho
