Re: [PATCH 1/2] Add for_each_remote() function, and extend remote_find_tracking()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 9 Jul 2007, Daniel Barkalow wrote:

> On Tue, 10 Jul 2007, Johannes Schindelin wrote:
> 
> > The function for_each_remote() does exactly what the name suggests.
> > 
> > The function remote_find_tracking() was extended to be able to search
> > remote refs for a given local ref.  You have to set the parameter
> > "reverse" to true for that behavior.
> 
> I think I'd like this better if reverse meant that it looked at 
> refspec->dst and set refspec->src, rather than returning the refspec 
> reversed; the current version sets the refspec so that it's effectively 
> something from the list, which makes it easier to understand.
> 
> Maybe make it so the user calls it with at most one of src and dst NULL, 
> and it returns with neither NULL or returns -1 if it can't find anything?

Will do.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux