On Mon, Feb 25, 2019 at 11:16:16PM +0000, Thomas Gummerer wrote: > +static int do_drop_stash(const char *prefix, struct stash_info *info, int quiet) This series hit next recently, so I started building it merged with my -Wunused-parameters series. This "prefix" parameter is not ever used. Skimming through the function, I don't see anything that _should_ be using it, so I think it's just cruft, and not indicative of a bug. The same is true of create_stash() elsewhere in the series. But there it might be worth keeping for consistency with the other top-level action functions. The other ones pass "prefix" to parse_options(), but create_stash() doesn't actually parse any options (and intentionally so, since even "--help" should be taken as part of the stash message). -Peff
