On Thu, Mar 07, 2019 at 09:50:57AM +0900, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > Mostly I was just surprised by the new behavior. Perhaps the right > > solution is not a patch to the code, but to the documentation. Something > > like: > > Let me forge your sign-off and commit this to prevent us from > forgetting. > > Thanks, all. Thanks for tying this up. One minor nit: > diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt > index 1bfe9f56a7..611a32445c 100644 > --- a/Documentation/git-config.txt > +++ b/Documentation/git-config.txt > @@ -240,7 +240,9 @@ Valid `<type>`'s include: > output. The optional `default` parameter is used instead, if > there is no color configured for `name`. > + > -`--type=color [--default=<default>]` is preferred over `--get-color`. > +`--type=color [--default=<default>]` is preferred over `--get-color` > +(but note that `--get-color` will omit the trailing newline printed by > +--type=color). That final line probably should have literal quotes, like: `--type=color`). -Peff
