Re: [PATCH] gitweb: snapshot cleanups & support for offering multiple formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/8/07, Junio C Hamano <gitster@xxxxxxxxx> wrote:
Matt McCutchen <hashproduct@xxxxxxxxx> writes:

> -sub gitweb_have_snapshot {
> -     my ($ctype, $suffix, $command) = gitweb_check_feature('snapshot');
> -     my $have_snapshot = (defined $ctype && defined $suffix);
> -
> -     return $have_snapshot;

Although you are removing this function, you still have a couple
of callers left in the code.

OK, I will revise the patch, submit it and see if I can get it to
appear as a reply to this thread.  Incidentally, when only one format
is offered, would you prefer the snapshot link to appear as
"_snapshot_" (the same as before) or "_snapshot (tgz)_" instead of the
"snapshot (_tgz_)" that the current patch does?

Matt
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux