Re: [PATCH 1/2] gitk: refresh the colour scheme

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/03/2019 00:02, Paul Mackerras wrote:
> On Tue, Feb 26, 2019 at 12:05:34PM +0100, Andrej Shadura wrote:
>> The colours gitk is currently using are from the basic 16 colour
>> palette, and are a bit too intensive to be comfortable or pleasant
>> to work with.
>>
>> Adjust the main colours (commit nodes, remotes, tags and one branch
>> colour) to be slightly softer.
>>
>> Signed-off-by: Andrej Shadura <andrew.shadura@xxxxxxxxxxxxxxx>
> 
> Thanks for the patch, but I disagree.  I do like the change you made
> to the tag colours, but the blue you have for the commit node circles
> is pretty blah.  That needs a more definite colour.

I see.

1) Would you accept the patch without that change?
2) What colour would you prefer (except the already existing one)?

> Also, the "too intensive to be comfortable or pleasant" in the commit
> message reflect a personal preference, and the way it is put seems to
> me to be too intensive to be comfortable or pleasant.

Hmm, sorry if that came across not the way I intended. I was trying to
formulate the thought in a way that would not be emotional or
subjective, but I guess the end result was exactly opposite.

-- 
Cheers,
  Andrej



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux