Hey Junio On 2019-03-03 13:20 UTC Junio C Hamano <gitster@xxxxxxxxx> wrote: > s/Add/add/. Strictly speaking, you do not need to say "new", if you > are already saying "add", then that's redundant. Oh, my mistake, I will change in coming revisions. > "test -s <path>" is true if <path> resolves to an existing directory > entry for a file that has a size greater than zero. Isn't it > redundant and wasteful to have test_path_is_file before it, or is > there a situation where "test -s" alone won't give us what we want > to check? Just to be clear of what caused the error: 1. Path not being file, or 2. File not being empty I am checking for both. Regards Rohit
