On Fri, Mar 01, 2019 at 06:50:20PM +0100, Alban Gruin wrote: > rafasc reported on IRC that on a repository with a lot of branches, > tags, remotes, and commits, name-rev --stdin could use a massive amount > of memory (more than 2GB of RAM) to complete. > > This patch series tries to improve name-rev’s memory usage. Have you tried this? diff --git a/builtin/name-rev.c b/builtin/name-rev.c index f1cb45c227..7aaa86f1c0 100644 --- a/builtin/name-rev.c +++ b/builtin/name-rev.c @@ -431,6 +431,8 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix) OPT_END(), }; + save_commit_buffer = 0; + init_commit_rev_name(&rev_names); git_config(git_default_config, NULL); argc = parse_options(argc, argv, prefix, opts, name_rev_usage, 0); It seems to lower heap usage of: git name-rev 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 in linux.git (that commit is the final one reported by "git log", so it's traversing all of history) from ~1GB to ~300MB. -Peff
