On Fri, Feb 22, 2019 at 04:05:45PM +0000, Olga Telezhnaya wrote: > Inline function stream_blob, it simplifies further > migrating process. I'd have to see what exactly gets simplified later on, but I'm mildly negative on this by itself. The reason this function was added in 98f425b453 (cat-file: handle streaming failures consistently, 2018-10-30) was to keep the outcomes consistent. The function right now isn't _too_ long, so we're really just duplicating the message text. But I wonder if it might eventually get more complicated, if we ever do the "future work" discussed in 98f425b453. So this seems like a step in the wrong direction. -Peff
