Re: [PATCH 1/1] tests: replace `test -(d|f)` with test_path_is_(dir|file)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/1] tests: replace `test -(d|f)` with test_path_is_(dir|file)
From: Martin Ågren <martin.agren@xxxxxxxxx>
Date: Wed, 27 Feb 2019 06:49:41 +0100
Cc: Johannes Schindelin <Johannes.Schindelin@xxxxxx>, Rohit Ashiwal via GitGitGadget <gitgitgadget@xxxxxxxxx>, Git Mailing List <git@xxxxxxxxxxxxxxx>, Junio C Hamano <gitster@xxxxxxxxx>, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>
In-reply-to: <CAL7ArXq37k2qmjLSB6DROq3K_wd0YaD9a-thNXgVwcxX7BEUMg@mail.gmail.com>
References: <pull.152.git.gitgitgadget@gmail.com> <bf5eb045795579dd5d996e787e246996688cf4bf.1551188524.git.gitgitgadget@gmail.com> <CAN0heSqSp-a0zUKT5EaGLBYnRtESTnu9GKWtGARz2kaOAhc1HQ@mail.gmail.com> <CAL7ArXoau1ZfBsV9JaUDprwjSijyo6K5d9JyC1mdfc=KEvgJxw@mail.gmail.com> <nycvar.QRO.7.76.6.1902262051080.41@tvgsbejvaqbjf.bet> <CAL7ArXq37k2qmjLSB6DROq3K_wd0YaD9a-thNXgVwcxX7BEUMg@mail.gmail.com>

On Tue, 26 Feb 2019 at 21:02, Rohit Ashiwal <rohit.ashiwal265@xxxxxxxxx> wrote:
>
> Hey!
>
> On Wed, Feb 27, 2019 at 1:22 AM Johannes Schindelin
> <Johannes.Schindelin@xxxxxx> wrote:
> >
> > We already have `test_path_is_missing`. Why not use that instead of `!
> > test -d` or `! test -f`?
> >
>
> Yes, I think this is better. It will satisfy all the requirements I guess.

Good suggestion, Johannes. That is probably what most (all) of these
wanted to express.

Martin

References:
- [PATCH 0/1] [GSoC][PATCH] tests: replace test -(d|f) with test_path_is_(dir|file)
  - From: Rohit Ashiwal via GitGitGadget
- [PATCH 1/1] tests: replace `test -(d|f)` with test_path_is_(dir|file)
  - From: Rohit Ashiwal via GitGitGadget
- Re: [PATCH 1/1] tests: replace `test -(d|f)` with test_path_is_(dir|file)
  - From: Martin Ågren
- Re: [PATCH 1/1] tests: replace `test -(d|f)` with test_path_is_(dir|file)
  - From: Rohit Ashiwal
- Re: [PATCH 1/1] tests: replace `test -(d|f)` with test_path_is_(dir|file)
  - From: Johannes Schindelin
- Re: [PATCH 1/1] tests: replace `test -(d|f)` with test_path_is_(dir|file)
  - From: Rohit Ashiwal

Prev by Date: Re: git rebase: retain original head?
Next by Date: [PATCH 0/1] Drop Windows XP-specific code to support IPv6
Previous by thread: Re: [PATCH 1/1] tests: replace `test -(d|f)` with test_path_is_(dir|file)
Next by thread: [PATCH v2 0/1] [GSoC][PATCH] t3600: use test_path_is_dir and test_path_is_file
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]