Hi, Jonathan Tan wrote: > Thanks, Peff, for noticing this. It's because the client sometimes sends > "0000" as a single request (that is, it flushes, and then before it > sends any data, it flushes again). And post_rpc() assumes that it can > always read something - which is usually correct, but not in this case; > we read in stateless_connect() first, and if we read "0000", we need to > tell post_rpc() to not read at all. > > This is a fixup on the tip of jt/http-auth-proto-v2-fix that fixes that. > > As for why the client sends a lone "0000", I'm not sure, but that's > outside the scope of this patch set, I think. > > Signed-off-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx> > --- > remote-curl.c | 32 +++++++++++++++++++------------- > 1 file changed, 19 insertions(+), 13 deletions(-) Tested-by: Jonathan Nieder <jrnieder@xxxxxxxxx> Thanks for fixing it. Is there a particular patch this should be squashed into, or does it stand alone? It the latter, mind writing a commit message for it? Thanks, Jonathan
