Hi Rohit, On Mon, Feb 25, 2019 at 12:36 PM Rohit Ashiwal <rohit.ashiwal265@xxxxxxxxx> wrote: > > Hey Christian > > On Mon, Feb 25, 2019 at 12:20 PM Christian Couder > <christian.couder@xxxxxxxxx> wrote: > > > In addition to what Dscho (alias Johannes Schindelin) wrote, please > > just send one patch that replaces `test -d`, `test -d` and similar > > code in only one t/tXXXX-*.sh file. No need to do more than that. > > I don't think I quite understood this. Were you asking for replacing > all `test -X` calls with `test_path_is_*` calls in only one tXXXX-*.sh > file or `test -d` calls with `test_path_is_dir` in all tXXXX-*.sh? As > of now, I've changed almost all `test -d` in all relevant tXXXX-*.sh > files. First on the micro-project page (https://git.github.io/SoC-2019-Microprojects/) there is "Please attempt only ONE microproject. We want quality, not quantity!" And the description of the micro-project you selected is: "Find a test script that verifies the presence/absence of files/directories with ‘test -(e|f|d|…)’ and replace them with the appropriate test_path_is_file, test_path_is_dir, etc. helper functions." This asks you to change only 1 test script, that is one t/tXXXX-*.sh file only. So yes I am asking for replacing all `test -X` calls with `test_path_is_*` calls in only one tXXXX-*.sh file. Thanks, Christian.
