Nicolas Pitre <nico@xxxxxxx> writes: > On Fri, 6 Jul 2007, Junio C Hamano wrote: > >> About the comment from Johannes regarding hunk_header vs >> funcname, I would actually prefer hunk_header, since that is >> what this is about ("funcname" and "find_func" were misnomer >> from the beginning), but I'd rename hunk_header to funcname for >> the sake of consistency and minimizing the diff. > > I think "minimizing the diff" in this case is a bad reason. Using > hunk_header is so much better than funcname IMHO. Well, even then it turns out to be a good reason, as the patch to rename function and field can be a separate patch. After adding that "latex pattern" stuff, I am even more inclined to rename them. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html