On Sun, 8 Jul 2007, Junio C Hamano wrote: > Daniel Barkalow <barkalow@xxxxxxxxxxxx> writes: > > > In addition to making fetch-pack a builtin, this allows it to be called > > directly from other built-in code without generating and parsing argument > > lists, which will be useful for builtin-fetch. > > > > Incidently, it makes git-fetch-pack not output lists of what it fetched > > when it fails. > > That sounds sensible. > > Hmmm. incidentally it seems to do a bit more than that. > > > @@ -663,15 +659,42 @@ static int fetch_pack_config(const char *var, const char *value) > > > > static struct lock_file lock; > > > > -int main(int argc, char **argv) > > +void setup_fetch_pack(const char *_uploadpack, > > ... > > +#if 0 > > + git_config(fetch_pack_config); > > + > > + if (0 <= transfer_unpack_limit) > > + unpack_limit = transfer_unpack_limit; > > + else if (0 <= fetch_unpack_limit) > > + unpack_limit = fetch_unpack_limit; > > +#endif > > +} > > This has been moved elsewhere? I do not see how the code now > honors the configuration. It's at the beginning of cmd_fetch_pack() for the case of running it from the command line, but it should probably also be an argument to setup_fetch_pack(). Got it added to my revisions, and I'll send out a new version once people have looked over this further. -Daniel *This .sig left intentionally blank* - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
