On Fri, Feb 22, 2019 at 6:55 AM brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Thu, Feb 21, 2019 at 08:10:00PM +0700, Duy Nguyen wrote: > > On Thu, Feb 21, 2019 at 2:41 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > Another mention of /dev/zero appears in t/helper/test-sha1.sh (not > > > to be confused with t/helper/test-sha1.c). This seems to be run > > > only with an explicit "make -C t/helper check-sha1" request, so > > > perhaps nobody on your platform ran it to get hit by it. I wonder > > > if anybody runs this on any platform, to be honest, though. > > > > I vaguely remember Brian added something to test SHA-512 performance > > but I can't find it. Maybe when he adds something (if it's not there > > already) we can retire this script, or update it to check sha-512 too. > > Doing git blame on that script seems to show that it was written mostly > by Junio. I think you may be thinking of test-tool hash-speed, which can > be used to benchmark a hash implementation. That's what I used for most > of my testing. > > We may not need both anymore, though. Well since you're basically killing sha-1 everywhere. I'll leave it to you to delete check-sha1.sh if you delete hash-speed too :) -- Duy
