On Mon, Feb 18, 2019 at 12:05 PM Michal Suchanek <msuchanek@xxxxxxx> wrote: > When adding wotktrees git can die in get_common_dir_noenv while > examining existing worktrees because the commondir file does not exist. > Rather than testing if the file exists before reading it handle ENOENT. This commit message leaves the reader wondering under what conditions "commondir file" might not exist. For instance, the reader might wonder "iIs it simply a condition of normal operation or does it arise under odd circumstances?". Without this information, it is difficult for someone reading the explanation to understand if or how this code might validly be changed in the future. Your cover letter contained explanation which likely ought to be duplicated here as an aid to future readers. > Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx>
