On February 18, 2019 13:46, Junio C Hamano wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > I have been wondering about the whole /dev/zero business. Although we > > have b46221ff ("Merge branch 'rb/no-dev-zero-in-test'", > > 2019-02-13) in 'master', "git grep /dev/zero t" has hits in > > t/helper/test-sha1.sh and t/t4152-am-resume-override-opts.sh, so it > > must have been somewhat incomplete to help platforms that lack > > /dev/zero in the first place. > > > > We haven't heard from Dscho in European timezone, but I'm inclined to > > > > - keep b46221ff in 'master', not reverted. > > - apply Max's "t5562: do not reuse output files" > > > > to 'master' and hope that we can declare victory in this part of the > > code ;-). There may be fix-ups for other topics before -rc2 on top of > > that, though. > > Just to make sure you didn't miss the exchange, the above plan is still the > latest ("Max's patch is [1]). As I'll be offline most of the day today, you still > have time to stop or make me change course to avoid disaster by interjecting > (which would be very much appreciated). No interjection expected. That is what I have been testing, so anticipate that this is correct.