Re: [PATCH v2] read-cache: add post-indexchanged hook

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes:

> On 14/02/2019 14:42, Ben Peart wrote:
>> From: Ben Peart <benpeart@xxxxxxxxxxxxx>
>> 
>> Add a post-indexchanged hook that is invoked after the index is written in
>
> s/post-indexchanged/post-index-changed/

Good.  I wasn't paying close attention to the previous round, but is
that the only name-related bikeshedding?  I somehow feel that
without s/changed/change/ the name does not roll well on my tongue
and does not sit well together with existing ones like post-receive
(which is not post-received).  I dunno.

Will queue.  Thanks.

>> do_write_locked_index().
>> 
>> This hook is meant primarily for notification, and cannot affect
>> the outcome of git commands that trigger the index write.
>> 
>> The hook is passed a flag to indicate whether the working directory was
>> updated or not and a flag indicating if a skip-worktree bit could have
>> changed.  These flags enable the hook to optmize its response to the
>
> s/optmize/optimize/
>
> ATB,
> Ramsay Jones



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux