Elijah Newren <newren@xxxxxxxxx> writes: >> There is also another side fix in remove_split_index() that causes a >> crash when doing "git update-index --no-split-index" when base_oid in >> the index file is null. In this case we will not load >> istate->split_index->base but we dereference it anyway and are rewarded >> with a segfault. This should not happen anymore, but it's still wrong to >> dereference a potential NULL pointer, especially when we do check for >> NULL pointer in the next code. >> >> Reported-by: Luke Diamand <luke@xxxxxxxxxxx> >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> > > Thanks for digging this down and fixing it. When I saw this split > index bug bisect to me that my heart sank a little; there's so much of > that code I don't understand. Nice to see you've already come along > and fixed it all up. :-) Thanks, all.
