On Mon, Feb 11, 2019 at 10:42:03PM +0100, Ismael Luceno wrote:
> Signed-off-by: Ismael Luceno <ismael@xxxxxxxxxxx>
> ---
> git-gui.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index 5bc21b878d41..e00d9a345294 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -3788,6 +3788,8 @@ bind $ui_comm <$M1B-Key-KP_Subtract> {show_less_context;break}
> bind $ui_comm <$M1B-Key-equal> {show_more_context;break}
> bind $ui_comm <$M1B-Key-plus> {show_more_context;break}
> bind $ui_comm <$M1B-Key-KP_Add> {show_more_context;break}
> +bind $ui_comm <Control-Key-BackSpace> {%W delete {insert -1 chars wordstart} insert;break}
> +bind $ui_comm <Control-Key-Delete> {%W delete insert {insert wordend};break}
I don't use git-gui and I don't understand TCL, but I was interested to
learn more about these key bindings in case other programs use them and
they might be useful in my day-to-day life.
However, your commit message doesn't include a body, so it isn't clear
to me what this change does and why these are useful keys for git-gui to
understand. Are they common among many programs? What do they do? Why
did we pick these keys instead of others?
Perhaps you could send a v2 with a more comprehensive commit message
that provides some of these answers.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
